Add integration test for pytorch-setup example#53
Open
Copilot wants to merge 4 commits into
Open
Conversation
Agent-Logs-Url: https://github.com/mila-iqia/cluv/sessions/1762a8c9-17d4-41b4-8310-08ce073ee54b Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add integration test for PyTorch example in GitHub CI
Add integration test for pytorch-setup example
May 12, 2026
lebrice
approved these changes
May 14, 2026
Contributor
|
@copilot Fix the conflicts and rebase on Master. |
Agent-Logs-Url: https://github.com/mila-iqia/cluv/sessions/0f9eec71-3a79-4740-9ea4-3bb7643d9a43 Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com>
Contributor
Author
Done — incorporated all master changes into the branch and resolved the Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Contributor
|
@copilot Resolve the conflicts and rebase on master |
Agent-Logs-Url: https://github.com/mila-iqia/cluv/sessions/b5d58953-7acc-419c-9d8c-cab1018aede4 Co-authored-by: lebrice <13387299+lebrice@users.noreply.github.com>
Contributor
Author
Done — incorporated changes from master commit Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
examples/pytorch-setupproject was not covered by any CI integration test, leaving it untested end-to-end.Changes
test_submit_pytorch_setup_exampleintests/test_integration.py: submitsexamples/pytorch-setup/scripts/job.shviacluv submit, polls for Slurm completion, syncs results, and asserts"PyTorch built with CUDA:"appears in the output log.chdirs intoexamples/pytorch-setupbefore submitting sofind_pyproject()/get_config()resolve against the example's ownpyproject.toml(including itsresults_path = "logs"and per-cluster env vars).get_configcache both before (to pick up the example config) and infinally(to avoid polluting subsequent tests).test_submit) to account for GPU scheduling latency; otherwise follows the same structure astest_submit.get_configto the existingfrom cluv.config import ...line.Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
releases.astral.sh/home/REDACTED/.local/bin/uv uv run pytest -m not integration -x --no-header -q(dns block)If you need me to access, download, or install something from one of these locations, you can either: